feat: support configurable branch name for 'main' and other defaults (fixes #523)#687
Open
li5435945-ship-it wants to merge 1 commit into
Open
Conversation
The branch name was hardcoded as 'master', causing the whitelist feature to fail when repositories use 'main' or other default branch names. Changes: - Add 'branch' parameter to page-attributes (defaults to 'master') - Make branch variable in github.ts configurable via setRepoContext() - Update error message link to use the configured branch Fixes utterance#523
li5435945-ship-it
force-pushed
the
fix/support-main-branch
branch
from
97e2655 to
a674be1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #523
The branch name was hardcoded as 'master', causing the whitelist feature to fail when repositories use 'main' or other default branch names.
Changes
Usage
Users can now specify the branch name in the utterances script tag:
If not specified, defaults to 'master' for backward compatibility.