Fix Delete() for invalid PID values#783
Open
priyamkarn wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for urunc canceled.
|
Author
|
The guard short-circuits before ever calling syscall.Kill when Pid <= 0. This covers both the reported case (Pid == -1, written by InitialSetup) and the degenerate Pid == 0 case. The Hedge branch is intentionally untouched — it never consults the PID at all, so it's not affected. |
Signed-off-by: priyamkarn <priyamkarn77@gmail.com>
1ff1d52 to
d86c8f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #778
This PR fixes
Delete()incorrectly treating containers with invalid PIDs (Pid <= 0) as running.Changes
falsefromisRunning()whenPid <= 0.syscall.Kill()from being invoked with invalid PID values.Why
InitialSetup()persists container state withPid = -1before container creation completes. If creation fails before the PID is updated,Delete()eventually callsisRunning(), which previously executedsyscall.Kill(-1, 0). On Unix systems, this can incorrectly succeed and cause the container to be considered running, preventing cleanup.With this change, containers in an incomplete state (
Pid <= 0) are correctly treated as not running, allowingDelete()to clean them up.