feat: add readme#3
Conversation
cmainas
left a comment
cmainas
left a comment
There was a problem hiding this comment.
Hello @7h3-3mp7y-m4n ,
I have added a comment for the figure of the architecture.
|
|
||
| ## Architecture | ||
|
|
||
| ``` |
There was a problem hiding this comment.
It would be better to use the image in the PR description for the architecture.
There was a problem hiding this comment.
Okay, I'll add that. Also, shall I choose the embedded scene option, the one you were showing on our recent sync?
There was a problem hiding this comment.
Yes, that would be useful.
cmainas
left a comment
cmainas
left a comment
There was a problem hiding this comment.
Thank you @7h3-3mp7y-m4n for the change, but it would be better to place the figure under a new directory.
There was a problem hiding this comment.
It would be better to create a directory and place this figure under it (e.g. images)
There was a problem hiding this comment.
Yeah, you are right, I was also thinking about that. I also opened a new PR regarding logo and favicon . We could add all those images in a directory like assets/image or something similar to that
Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
|
Hello @7h3-3mp7y-m4n , I think we are missing the image for the readme. |
|
@7h3-3mp7y-m4n @cmainas the gh api command Cannot parse runs_raw.json: json: cannot unmarshal number into Go value of type main.WorkflowsResponse
exit status 1Would it make sense to replace this manual step with a makefile and have a script to fetch the data? |
3 participants
Added Readme.md
I have also made a cleaner architecture from excalidraw. If needed, we can also add this: