Scan rewrite#4308
Draft
je-cook wants to merge 6 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4308 +/- ##
==========================================
+ Coverage 48.85% 49.68% +0.82%
==========================================
Files 151 151
Lines 29469 29112 -357
==========================================
+ Hits 14397 14464 +67
+ Misses 15072 14648 -424 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
34b4e19 to
49649f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #3928
Rewrites Scan to be more flexible for different scanning methods. Cleans up scan plotting which was 1/3 duplicated code
Checklist
I confirm that I have completed the following checks: