Skip to content

Scan rewrite#4308

Draft
je-cook wants to merge 6 commits into
ukaea:mainfrom
je-cook:scan
Draft

Scan rewrite#4308
je-cook wants to merge 6 commits into
ukaea:mainfrom
je-cook:scan

Conversation

@je-cook

@je-cook je-cook commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Description

Closes #3928

Rewrites Scan to be more flexible for different scanning methods. Cleans up scan plotting which was 1/3 duplicated code

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@codecov-commenter

codecov-commenter commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 28.47966% with 334 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.68%. Comparing base (e5c6faf) to head (49649f3).

Files with missing lines Patch % Lines
process/core/io/plot/scans.py 12.87% 203 Missing ⚠️
process/core/scan.py 45.66% 119 Missing ⚠️
process/core/solver/solver_handler.py 20.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4308      +/-   ##
==========================================
+ Coverage   48.85%   49.68%   +0.82%     
==========================================
  Files         151      151              
  Lines       29469    29112     -357     
==========================================
+ Hits        14397    14464      +67     
+ Misses      15072    14648     -424     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@je-cook je-cook force-pushed the scan branch 2 times, most recently from 34b4e19 to 49649f3 Compare June 16, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ease of use of scan plotting

2 participants