Convert numerics vars to dataclass#4306
Open
clmould wants to merge 2 commits into
Open
Conversation
clmould
force-pushed
the
Numerics-Vars_Dataclass
branch
from
839dd0f to
f0b9e2a
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4306 +/- ##
==========================================
- Coverage 48.76% 48.65% -0.11%
==========================================
Files 151 151
Lines 29325 29269 -56
==========================================
- Hits 14299 14241 -58
- Misses 15026 15028 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
74 tasks
clmould
force-pushed
the
Numerics-Vars_Dataclass
branch
from
f0b9e2a to
4dd9ca6
Compare
clmould
force-pushed
the
Numerics-Vars_Dataclass
branch
from
4dd9ca6 to
004de62
Compare
timothy-nunn
requested changes
Jun 16, 2026
| ): | ||
| objf_list = norm_objf_df[NORM_OBJF_NAME].unique() | ||
| else: | ||
| numerics.init_numerics() |
Collaborator
There was a problem hiding this comment.
This was clearly being done for a reason before. Can you check that plot solutions does not change before and after because of removing this statement.
| """Base class for different solver implementations.""" | ||
|
|
||
| def __init__(self, *, maxcal: int | None = None): | ||
| def __init__(self, *, data: DataStructure, maxcal: int | None = None): |
Collaborator
There was a problem hiding this comment.
If we are passing the data structure in we can remove the maxcal argument and just get it from self.data
| elif solver_name == "fsolve": | ||
| solver = FSolve() | ||
| solver = FSolve( | ||
| data=data, |
Collaborator
There was a problem hiding this comment.
Suggested change
| data=data, | |
| data=data |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
I confirm that I have completed the following checks: