-
Notifications
You must be signed in to change notification settings - Fork 18
♻️ Refactor CS coil stresses #4262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
c2b0246
Rename hoop_stress method to calculate_cs_hoop_stress and update refe…
chris-ashe f3a842d
Enhance CS hoop stress calculation with additional parameters and upd…
chris-ashe 1c116e3
Refactor CS hoop stress calculation to include additional parameters …
chris-ashe 2392be2
Rename sig_hoop variable to stress_hoop_cs for clarity and update ref…
chris-ashe cae09dc
Update CSCoil docstring to clarify parameters and add reference for h…
chris-ashe b736a02
Rename stress_hoop_cs variable to stress_hoop_cs_inner for clarity an…
chris-ashe 2cc4fe9
Add stress_hoop_cs_inner_profile variable and update initialization i…
chris-ashe 15cd5ba
Add a_cs_steel_poloidal variable and update initialization in PF coil…
chris-ashe cf25008
Refactor CSCoil to calculate a_cs_steel_poloidal directly and update …
chris-ashe c104b6a
Update output to reference a_cs_steel_poloidal in PF coil module
chris-ashe ebca687
Refactor variable names from awpoh to a_cs_cable_space across multipl…
chris-ashe 2784d3c
Add inner and outer radius variables for central solenoid in PF coil …
chris-ashe ead9cce
Add radial inner and outer parameters for central solenoid in PF coil…
chris-ashe 7c9f17c
Add radial hoop stress profile plotting to CSCoil class and update pa…
chris-ashe 5f925f3
Refactor CSCoil class to add radial stress profile calculations and u…
chris-ashe f3e3861
Refactor CSCoil class to rename and enhance magnetic field calculatio…
chris-ashe 3b1576b
Add peak field variable for central solenoid bore in PF coil module
chris-ashe 3e2d4e4
Add magnetic field variable for outer edge of central solenoid at mid…
chris-ashe 7490951
Add operating temperature variable for central solenoid and update in…
chris-ashe b7c88ef
Update operating temperature for central solenoid superconductor
chris-ashe ebafb43
Post rebase fixes
chris-ashe 6c3c978
Update unit test
chris-ashe 951f2be
Add CSGeometry dataclass
chris-ashe 41cc3df
Refactor CS stress plotting functions for clarity and consistency
chris-ashe 51034bf
Update docs
chris-ashe ce7e640
:sparkle: Add `a_cs_toroidal` to store the top down cross section
chris-ashe 3e33e93
Update CS geometry docs
chris-ashe e97aa88
Add EU DEMO turn geometry calculations and update tests
chris-ashe b01e3b1
Refactor central solenoid variable descriptions for clarity and consi…
chris-ashe 39ad4a9
Refactor output comments and streamline superconductor information in…
chris-ashe fcc432b
Refactor output formatting in PFCoil model for improved readability a…
chris-ashe 4218c94
Update integration test MFILE data to include new CS outputs and prev…
chris-ashe 691e184
Post rebase fixes
chris-ashe df47454
Apply suggestions from code review
chris-ashe 3cd0b37
Update type hint for central solenoid radial stress calculation to su…
chris-ashe 098de75
Post rebase fixes
chris-ashe 5e2e418
Set Poisson's ratio for steel structure to a constant value of 0.3 in…
chris-ashe 905b38f
Test each field of CSGeometry in unit tests
timothy-nunn 27b0aac
Post rebase fixes
chris-ashe b9af917
Add functions to plot CS radial hoop and radial stress profiles
chris-ashe eb6a14e
Refactor CSCoil methods to static and update stress profile plotting …
chris-ashe d128a38
Add radiation power variables for inboard and outboard first wall in …
chris-ashe 5ef3d42
Revert "Add radiation power variables for inboard and outboard first …
chris-ashe 7c9ef8f
Update beta range conditions in conductor peak field calculations
chris-ashe 6536bde
Post rebase commit
chris-ashe 9d4d67f
Apply suggestions from code review
chris-ashe 5474f67
Refactor CSCoil calculations to use b_cs_outer for outer radius field…
chris-ashe f361860
Update documentation/source/eng-models/central-solenoid.md
chris-ashe 6e70b59
Update documentation/source/eng-models/central-solenoid.md
chris-ashe 269b504
Refactor Poisson's ratio usage in stress profile calculations to use …
chris-ashe 2b1933d
Refactor PFCoil output methods to use tabulate for improved readabili…
chris-ashe a47a259
Refactor CSCoil peak field calculations to use updated variable names…
chris-ashe 28a60f6
Apply suggestions from code review
je-cook e06a93c
Remove redundant output operations for central solenoid dimensions in…
chris-ashe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clmould marked this conversation as resolved.
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.