Skip to content

e2eの失敗要因だった単一コマンドE2Eセレクタを現行テストページ構造に同期 #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ujiro99 merged 3 commits into from
Jul 16, 2026
Merged

e2eの失敗要因だった単一コマンドE2Eセレクタを現行テストページ構造に同期 #435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb5eb42
Initial plan
Copilot Jul 15, 2026
288f32f
test: update e2e selectors for current hub test page
Copilot Jul 15, 2026
e8fbd58
Update: SearchUrl of the OLX.
ujiro99 Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/extension/e2e/generated-command-urls.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const COMMAND_URLS: UrlEntry[] = [
{ title: "AliExpress", locale: "es", searchUrl: "https://es.aliexpress.com/w/wholesale-%s.html" },
{ title: "Buscar comandos en Hub", locale: "es", searchUrl: "https://selection-command.com/es?q=%pageUrl" },
{ title: "Pesquisar comandos no Hub", locale: "pt-br", searchUrl: "https://selection-command.com/pt-BR?q=%pageUrl" },
{ title: "OLX", locale: "pt", searchUrl: "https://www.olx.pt/ads/?q=%s" },
{ title: "OLX", locale: "pt", searchUrl: "https://www.olx.pt/ads/q-%s/" },
{ title: "Pesquisar comandos no Hub", locale: "pt", searchUrl: "https://selection-command.com/pt-PT?q=%pageUrl" },
{ title: "Hub पर कमांड खोजें", locale: "hi", searchUrl: "https://selection-command.com/hi?q=%pageUrl" },
{ title: "Tokopedia", locale: "id", searchUrl: "https://www.tokopedia.com/search?st=product&q=%s" },
Expand Down
13 changes: 5 additions & 8 deletions packages/extension/e2e/single-command.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ test.describe("Single Function Commands", () => {
await context.grantPermissions(["clipboard-read", "clipboard-write"])
const testPage = new TestPage(page)
await testPage.open()
await testPage.selectText("h1")
await testPage.selectText("h2")
const selectedText = await page.evaluate(
() => window.getSelection()?.toString() ?? "",
)
Expand All @@ -44,20 +44,17 @@ test.describe("Single Function Commands", () => {
})

/**
* E2E-31: Verify that the Link Popup command opens each link in the selected range in a popup window.
* E2E-31: Verify that the Link Popup command opens the selected link in a popup window.
*/
test("E2E-31: link popup command opens each selected link in a popup window", async ({
test("E2E-31: link popup command opens the selected link in a popup window", async ({
page,
context,
}) => {
// Arrange: open the test page and select a range spanning multiple links
// Arrange: open the test page and select a link
const testPage = new TestPage(page)
await testPage.open()
const initialPageCount = context.pages().length
await testPage.selectRange(
"footer a[href$='terms']",
"footer a[href$='cookie']",
)
await testPage.selectRange("a[download='test.txt']", "a[download='test.txt']")

// Act: click the "リンクポップアップ" menu item and wait for a new page to open
const menubar = await testPage.getMenuBar()
Expand Down
2 changes: 1 addition & 1 deletion packages/extension/src/services/option/defaultSettings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1039,7 +1039,7 @@ const CMD_OLX_PT = {
iconUrl: "https://www.olx.pt/favicon.ico",
openMode: OPEN_MODE.TAB,
openModeSecondary: OPEN_MODE.TAB,
searchUrl: "https://www.olx.pt/ads/?q=%s",
searchUrl: "https://www.olx.pt/ads/q-%s/",
title: "OLX",
parentFolderId: FOLDER_SEARCH,
popupOption: { width: PopupOption.width, height: PopupOption.height },
Expand Down
Loading