derive Outcome from TangoError error codes - #244
Merged
Conversation
Replace the hardcoded failure/cancelled switch in metrics.Outcome with a delegation to tangoerrors.GetErrorCode, which returns the error's classified code (infra, cancelled, user, infra_retryable). This gives the finish histogram's result tag full error-code granularity instead of collapsing everything non-cancelled into "failure". Remove the now-unused ResultFailure and ResultCancelled constants.
justinwon777
approved these changes
Jul 27, 2026
xytan0056
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
failure/cancelledswitch inmetrics.Outcomewith a delegation totangoerrors.GetErrorCode, which returns the error's classified code (infra,cancelled,user,infra_retryable).resulttag full error-code granularity instead of collapsing everything non-cancelled into"failure".ResultFailureandResultCancelledconstants.Test plan
TestOutcomeandTestBeginCompleteto cover all four error codesmake test— all 23 tests pass