fix(cachekey): include ordered request commits - #239
Merged
Conversation
Include each change request URL and commit in caller order with length framing so distinct build descriptions cannot share a treehash cache entry. Add Rapid properties asserting that changing a commit or reordering change requests changes the cache path.
xytan0056
reviewed
Jul 24, 2026
| return fmt.Sprintf("%x", h.Sum(nil)) | ||
| } | ||
|
|
||
| func writeFramedString(h hash.Hash, value string) { |
Contributor
There was a problem hiding this comment.
worth dedupe from the one in cachekey https://github.com/uber/tango/blob/main/core/cachekey/cachekey.go#L86
xytan0056
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a similar patch to #228, against internal/url.
Include each change request URL and commit in caller order with length framing so distinct build descriptions cannot share a treehash cache entry.
Add Rapid properties asserting that changing a commit or reordering change requests changes the cache path.