feat(stovepipe)!: key the record stage on the request id

[behinddwalls]

Summary

Why?

buildsignal published the build id to record, but record's unit of work is a Request: it writes whole-repo greenness for the Request's URI, advances the Queue's last-green bookmark, and fires Hooks. Keying its input on a build artifact forces every future reader to navigate Build→Request, and it bakes a one-build-per-Request assumption into the wire contract.

The assumption is also the wrong one to encode. The concurrency knob gates how many Requests are in flight per Queue — same base, different head, one build each — so the fan-out axis is Queue→N Requests, not Request→N Builds. And if a Request ever did fan out, a build-keyed input would give record N messages with no way to tell "one build failed" from "one failed and three haven't reported yet". A request-keyed input lets record answer its own question.

What?

Record.id now carries the request id, and publishRecord uses it for the payload, the message id, and the partition key. The field name stays id, matching ProcessRequest.id and BuildRequest.id. Partitioning is unchanged — it was already request id — so the only wire change is what the payload means.

No reverse index is needed to make this work: the previous commit projects the build's terminal status onto Request.State, so record reads the Request and never reaches a Build. That also leaves the "no reverse index from Request to its builds" property in build.md intact, for a better reason than before, and the derived-build-key alternative explicitly untriggered — its condition is a stage that must derive a build's key from a Request, which record no longer does.

Marked ! because the record topic's payload semantics change. Nothing consumes it yet — the record stage lands later — so there is no migration.

Test Plan

✅ bazel test //stovepipe/... — new unit test pins that the record payload, message id, and partition key are all the request id.

✅ bazel test //test/e2e/stovepipe/... — the slow-build case now additionally asserts the request reaches succeeded and the queue's in_flight_count returns to 0.

Conflicts:

stovepipe/controller/buildsignal/buildsignal_test.go

Please enter the commit message for your changes. Lines starting

with '#' will be kept; you may remove them yourself if you want to.

An empty message aborts the commit.

interactive rebase in progress; onto b1937b43

Last command done (1 command done):

pick d3e6221a feat(stovepipe)!: key the record stage on the request id

No commands remaining.

You are currently rebasing branch 'preetam/stovepipe-record-request-id' on 'b1937b43'.

Changes to be committed:

modified: doc/rfc/stovepipe/steps/build.md

modified: doc/rfc/stovepipe/steps/buildsignal.md

modified: doc/rfc/stovepipe/workflow.md

modified: stovepipe/controller/buildsignal/buildsignal.go

modified: stovepipe/controller/buildsignal/buildsignal_test.go

modified: stovepipe/core/messagequeue/proto/record.proto

modified: stovepipe/core/messagequeue/protopb/record.pb.go

modified: stovepipe/core/messagequeue/topics.go

modified: test/e2e/stovepipe/harness_test.go

modified: test/e2e/stovepipe/suite_test.go

Stack

1. test(stovepipe): add build-slow marker to the fake build runner #464
2. fix(stovepipe): mint a distinct message id for each buildsignal re-poll #465
3. refactor(stovepipe): replace recorded greenness states with build outcomes #466
4. feat(stovepipe): record the build outcome on the request and free its slot #467
5. @ feat(stovepipe)!: key the record stage on the request id #468
6. fix(stovepipe): stop wrapping the buildsignal re-poll publish as retryable #469