feat(storage): add request batch assignments - #452
Closed
ubettigole wants to merge 1 commit into
Closed
Conversation
Add an immutable request-to-batch mapping store and wire its MySQL implementation into the storage extension. Jira Issues: CODEM-304
This was referenced Jul 29, 2026
ubettigole
marked this pull request as ready for review
July 29, 2026 00:40
ubettigole
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
July 29, 2026 00:40
sbalabanov
requested changes
Jul 29, 2026
sbalabanov
left a comment
sbalabanov
left a comment
Contributor
There was a problem hiding this comment.
This is by design. When batching failed, a batch with new id is created and pipeline restarted. Batch dependent store should be tolerant to races (non-existing batch ids).
submitqueue/orchestrator/controller/batch/batch.go has an explanation starting line 200.
Could use a better model to validate if these assumptions still hold true.
Contributor
Author
|
This immutable request-to-batch assignment approach is no longer part of the revised stack. The replacement stack preserves fresh batch IDs on retry and starts at #453. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch creation does not currently persist which batch owns a request. If processing fails after claiming the request or partially persisting a batch, redelivery can create a new batch ID, leaving duplicate or orphaned batches and stale dependency-graph entries.
This foundational PR adds an immutable request-to-batch assignment store and its MySQL implementation. Later PRs use this mapping to resume the original batch and allow cancellation to resolve durable batch ownership. This PR does not change controller behavior itself.
Test Plan
Unit tests
Issues
#354
Stack