Skip to content

fix: use the client timeout in AsyncTwilioHttpClient when none is passed - #955

Open
Hashim1999164 wants to merge 1 commit into
twilio:mainfrom
Hashim1999164:fix/async-http-client-timeout
Open

fix: use the client timeout in AsyncTwilioHttpClient when none is passed#955
Hashim1999164 wants to merge 1 commit into
twilio:mainfrom
Hashim1999164:fix/async-http-client-timeout

Conversation

@Hashim1999164

@Hashim1999164 Hashim1999164 commented Aug 16, 2026

Copy link
Copy Markdown

Fixes #925

AsyncTwilioHttpClient.request ignored the timeout set on the client when the request did not pass one. The sync client already falls back to the client timeout in that case.

This matches that behavior and adds unit tests that check the timeout passed to aiohttp.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] AsyncTwilioHttpClient.request does not use self.timeout

1 participant