fix(vm): encode Elixir nil to Lua nil instead of the string "nil"#375
Open
smn wants to merge 1 commit into
Open
fix(vm): encode Elixir nil to Lua nil instead of the string "nil"#375smn wants to merge 1 commit into
smn wants to merge 1 commit into
Conversation
`Lua.encode!/2` matched `nil` in its atom-encoding head (`nil` is an atom that is not a boolean) and converted it to the string `"nil"`. Because all Lua strings are truthy, encoded `nil` silently inverted `if not value then` checks and broke `return nil, "reason"` error-tuple patterns, and the round trip `decode!(encode!(nil))` was lossy. Add a dedicated `encode!/2` head that maps Elixir `nil` to Lua `nil`, matching `decode!/2` and the existing handling of `nil` inside tables and function result lists. Fixes tv-labs#374
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #374
full disclosure: Claude helped here