[pull] master from ruby:master#1129
Merged
Merged
Conversation
Cover the cases where folding a Fixnum add/sub/mult would overflow RUBY_FIXNUM_MAX/MIN into a Bignum, asserting the fold is rejected and the FixnumAdd/Sub/Mult node is kept. FixnumDiv is omitted because `test_dont_fold_fixnum_div_negative_one_overflow` already covers its only overflow case (RUBY_FIXNUM_MIN / -1). FixnumMod is omitted, a % b is bounded by |b| and can never overflow.
…value ruby/json@e5fa06aa42 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…n an empty buffer ruby/json@3927c5ca4c Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ruby/json@489b8c13b9 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ruby/json@d91b370b1e Co-Authored-By: Jean Boussier <jean.boussier@gmail.com>
ruby/json@56d16deb46 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
cursor_position consumed the newline ending the previous line (post-decrement) before counting lines, so any error past the first line was reported one line too low (e.g. "[1,\n@" reported '@' at line 1 instead of line 2). Count that newline when the column loop breaks on it. ruby/json@82b6b21354 Co-Authored-By: Jean Boussier <jean.boussier@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )