[pull] master from ruby:master#1128
Merged
Merged
Conversation
The POSIX make jobserver passes tokens through an inherited pipe identified by file descriptor numbers, which Windows cannot inherit, and nmake aborts every native extension build with `fatal error U1065: invalid option '-'` when it finds the GNU make `--jobserver-auth` left in MAKEFLAGS. Skip the jobserver entirely on Windows so bundle install keeps working with nmake. https://github.com/ruby/rbs/actions/runs/27736519019/job/82054372031 ruby/rubygems@0c434ba2cd Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The example exercises the genuine Windows code path, so tag it `windows_only` and exclude it elsewhere instead of stubbing `Gem.win_platform?`. ruby/rubygems@479d03dc26 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The first version skipped the jobserver on every Windows platform, but mingw uses GNU make and consumes the jobserver tokens through the inherited pipe without trouble. Only nmake on mswin reads MAKEFLAGS as bare option letters and rejects the GNU make `--jobserver-auth`. Detect nmake the way the extension builder does and skip the jobserver only then, so mingw keeps building in parallel. ruby/rubygems@b12db473de Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Instead lets run a single sweep step per heap and see if we can reduce malloc_increase enough to carry on without requiring a complete sweep finish and a big pause
It's only testing if we run into a parsing error or not, not testing the actual parsed value, but that's still useful to help ensure we're not changing behavior on dark corners of the spec. ruby/json@5973ecf23e
Claude-Session: https://claude.ai/code/session_01LAnsPXaSaGWrYuf87rrtp1 Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )