[pull] master from ruby:master#1122
Merged
Merged
Conversation
The tests under `with_inlining` are meant to verify that inlining a callee preserves the method's semantics, but many of them called the entry method too few times to ever trigger compilation. With the test call threshold of 2, a method is compiled on its second call and that same call runs the freshly compiled body, so a test that called the entry method only once never crossed the threshold and never compiled it at all. Those tests passed purely on the interpreter's result, leaving the inliner untested while appearing to cover it. The new `assert_inlines` will help catch issues like this in the future.
The cross-workflow artifact upload from wasm.yml is frequently invisible to this workflow_run handler, so the hard throw turned every non-PR run red. Treat a missing artifact like the other best-effort skips (no Playground label, no successful build) and bail out quietly. The underlying artifact visibility in wasm.yml is a separate matter.
The changeset fetch is a best-effort trigger that Redmine also polls on its own, so a transient 503 from it should not turn the whole post-push job red while the load-bearing git.ruby-lang.org sync has already succeeded. Mark the step continue-on-error like the other non-critical steps already are.
File.readlines slurps each Ractor's whole ~8MB dump into memory at once. Because dump_all dumps the shared heap, the concurrent Ractors' readlines buffers feed back into each other's dumps, so peak memory grows superlinearly and the stop-the-world barrier thrashes past the 100s timeout on macOS/M:N. File.foreach keeps peak memory flat (NR=16: 2.96GB -> 47MB) while still parsing every line. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )