Skip to content

Improvements and fixes on logging#61

Open
bugrasan wants to merge 1 commit into
trustcrypto:masterfrom
bugrasan:ImprovementsAndFixesOnLogging
Open

Improvements and fixes on logging#61
bugrasan wants to merge 1 commit into
trustcrypto:masterfrom
bugrasan:ImprovementsAndFixesOnLogging

Conversation

@bugrasan
Copy link
Copy Markdown

Since we get the module specific logger with logging.getLogger(__name__) we should use that one.

Since we get the module specific logger with `logging.getLogger(__name__)`
we should use that one.
@tickzip
Copy link
Copy Markdown

tickzip commented Jun 4, 2026

When I tested this, I found an unintended side effect where the PR now causes asyncio's debug messages to appear in the terminal:

tickzip@guix ~> onlykey-cli
OnlyKey CLI v1.2.10
Control-D to exit.


DEBUG:asyncio:Using selector: EpollSelector
OnlyKey>

I managed to narrow it down to this line as the cause, but I can't think why it triggers these debug messages.

log.debug('connected')

I was also able to suppress the messages using

logging.getLogger('asyncio').setLevel(logging.WARNING)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants