Skip to content

AGE-1957: Pass create_turn turn through without any fallback. #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhaveshpatel640 merged 1 commit into from
Aug 25, 2026
+2 −26
Merged

AGE-1957: Pass create_turn turn through without any fallback. #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 2 additions & 26 deletions src/truefoundry_gateway_sdk/agents/prepared_turn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,19 +353,7 @@ def _must_get_turn(self) -> Turn:

def _adopt_turn_from_api(self, turn: RawTurn) -> None:
"""Build the inner Turn from create_turn / get_turn response data."""
self._turn = Turn(
RawTurn(
id=turn.id,
session_id=turn.session_id,
previous_turn_id=turn.previous_turn_id,
input=turn.input if turn.input is not None else self._input, # type: ignore[arg-type]
state=turn.state,
created_by_subject=turn.created_by_subject,
created_at=turn.created_at,
),
self._session,
self._client,
)
self._turn = Turn(turn, self._session, self._client)

@chiragjn chiragjn Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as TS, do we need to copy turn if Turn mutates it in anyway?

same for self._session

--

same comment for async

@bhaveshpatel640 bhaveshpatel640 Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as TS, do we need to copy turn if Turn mutates it in anyway?

same for self._session

  • Turn (src/truefoundry_gateway_sdk/agents/turn.py) only reads fields onto self, later updates reassign self._state, never the passed-in turn

  • Session (AgentSession / AgentDraftSession): constructor copies fields from the raw session; does not write back. Draft update() only reassigns private fields from the new response

same comment for async

AsyncTurn / AsyncAgentSession / AsyncAgentDraftSession mirror the sync constructors and only reassign private fields from new responses.


def _adopt_turn_from_created_event(self, event: TurnCreatedEvent) -> None:
"""Build the inner Turn directly from the turn.created event."""
Expand Down Expand Up @@ -733,19 +721,7 @@ def _must_get_turn(self) -> AsyncTurn:
return self._turn

def _adopt_turn_from_api(self, turn: RawTurn) -> None:
self._turn = AsyncTurn(
RawTurn(
id=turn.id,
session_id=turn.session_id,
previous_turn_id=turn.previous_turn_id,
input=turn.input if turn.input is not None else self._input, # type: ignore[arg-type]
state=turn.state,
created_by_subject=turn.created_by_subject,
created_at=turn.created_at,
),
self._session,
self._client,
)
self._turn = AsyncTurn(turn, self._session, self._client)

def _adopt_turn_from_created_event(self, event: TurnCreatedEvent) -> None:
self._turn = AsyncTurn(
Expand Down
Loading