feat(branding): introduce support for icon-only branding and better flexibility - #428
Open
govindavashishtha wants to merge 4 commits into
Open
feat(branding): introduce support for icon-only branding and better flexibility#428govindavashishtha wants to merge 4 commits into
govindavashishtha wants to merge 4 commits into
Conversation
… logo configurations - Added new type to support square icons and optional wide logos. - Updated theme documentation to reflect changes in branding options. - Implemented logic for rendering icons and logos based on the theme mode. - Introduced fallback mechanisms for compact and expanded surfaces. - Updated examples and tests to demonstrate new branding capabilities.
govindavashishtha
requested review from
kumarsks619,
qaifi-tf,
sajal-truefoundry,
sayan-truefoundry and
vinit-truefoundry
as code owners
August 25, 2026 07:49
🦋 Changeset detectedLatest commit: 3ed36de The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cbc4d79. Configure here.
Hosts pick icon-title, icon-only, or logo first; name always labels the mark, and resolveBrandChrome drives sidebar chrome. Co-authored-by: Cursor <cursoragent@cursor.com>
| <span className="truncate text-lg font-semibold tracking-tight">{brandName}</span> | ||
| <BrandLogo | ||
| variant={chrome.expandedVariant} | ||
| className={cn('h-5 max-w-40 shrink-0 object-contain', chrome.expandedVariant === 'icon' && 'w-5')} |
Contributor
There was a problem hiding this comment.
can we extract this out in a separate constant and reuse it ?
As the same class is being used above
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
theme.brand.modeso hosts pick chrome look first:icon-title|icon-only|logo(omitbrandfor default TrueForge marks).BrandConfigis a discriminated union onmode.nameis required and always labels the mark (alt/aria-label); visible title text only foricon-title.icon. Expanded chrome useslogowhenmode: 'logo', otherwiseicon(+ title whenicon-title).resolveBrandChrome()mapsmode→{ expandedVariant, collapsedVariant, showTitle };SidebarLayoutuses it instead of field heuristics.Contract
brand.modebrand'icon-title'name(+ optionalicon)'icon-only'name,icon'logo'name,icon,logoUsage