Skip to content

fix: preserve Helm chart prerelease mode - #394

Merged
chiragjn merged 3 commits into
truefoundry:mainfrom
jayesh9747:fix/helm-chart-prerelease-version-upstream
Aug 25, 2026
Merged

fix: preserve Helm chart prerelease mode#394
chiragjn merged 3 commits into
truefoundry:mainfrom
jayesh9747:fix/helm-chart-prerelease-version-upstream

Conversation

@jayesh9747

@jayesh9747 jayesh9747 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • use the app version only to select stable or prerelease mode
  • keep the chart numeric core and RC counter independent from the app version
  • start a chart prerelease at rc.0 and advance from the latest chart RC on main or the open chart PR
  • stabilize the in-progress chart core when prerelease mode ends, then resume patch bumps
  • preserve a reviewed higher chart core from the open chart PR

Expected lifecycle:

0.1.5 → 0.1.6-rc.0 → 0.1.6-rc.1 → 0.1.6 → 0.1.7

Validation

  • pnpm test:chart-version
  • pnpm format:check
  • git diff --check

Closes #384.


Note

Medium Risk
Changes release automation that sets published Helm chart versions; behavior is covered by new tests but mistakes would affect OCI chart tags.

Overview
Fixes chart release versioning so prerelease app builds get matching -rc.N chart versions instead of only patch bumps on stable cores.

The build-and-prepare-chart-release workflow no longer inlines semver math and PR-branch comparisons. It still reads the open release-chart/trueforge branch for a reviewer-bumped version, then delegates to scripts/resolve-chart-version.sh, which picks the numeric core (patch bump from stable main, hold core across RCs, stabilize when the app goes stable), uses app version only for stable vs prerelease mode, maintains a chart-local RC counter (not tied to the app’s prerelease suffix), and keeps a higher core from the open chart PR.

Adds pnpm test:chart-version and shell tests covering stable bumps, RC progression, stabilization, and preserved PR cores.

Reviewed by Cursor Bugbot for commit 22521c7. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI lite review requested due to automatic review settings August 21, 2026 11:37
@changeset-bot

changeset-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 22521c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes Helm chart version resolution to preserve app prerelease lanes while keeping chart numbering independent.

Changes:

  • Adds a tested chart-version resolver.
  • Preserves higher chart versions and same-lane RC counters.
  • Integrates regression tests into CI and the release workflow.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Summary
tests/scripts/resolve-chart-version.test.sh Adds chart-version regression cases.
scripts/resolve-chart-version.sh Resolves chart versions and prerelease counters.
package.json Adds the chart-version test script.
.github/workflows/ci.yml Runs focused chart-version tests.
.github/workflows/build-and-prepare-chart-release.yml Uses the centralized resolver during chart preparation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ceae07d. Configure here.

Comment thread scripts/resolve-chart-version.sh

@chiragjn chiragjn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good to go, added minor comments

Comment thread tests/scripts/resolve-chart-version.test.sh Outdated
Comment thread .github/workflows/ci.yml Outdated
@jayesh9747

Copy link
Copy Markdown
Contributor Author

@chiragjn Thanks for the review! I’ve addressed and resolved both comments. Could you please take another look when you have a chance?

@chiragjn

Copy link
Copy Markdown
Member

@jayesh9747 not seeing any changes pushed to this branch addressing the comments, can you please check if commit was pushed from your local?

@jayesh9747

Copy link
Copy Markdown
Contributor Author

@chiragjn let me check

@jayesh9747

Copy link
Copy Markdown
Contributor Author

My bad — I had addressed the review comments locally but had not pushed the changes. The requested updates are now pushed in commit 5a34ee2, and both review threads have been resolved. Could you please take another look?

The chart version calculation ignored the prerelease suffix already carried by the published app version. Resolve chart versions through a tested helper so RC mode and reviewed chart bumps survive workflow updates.

Signed-off-by: Jayesh Savaliya <jsavaliya.tech@gmail.com>
Signed-off-by: Jayesh Savaliya <jsavaliya.tech@gmail.com>
@chiragjn
chiragjn force-pushed the fix/helm-chart-prerelease-version-upstream branch from 5a34ee2 to 22521c7 Compare August 25, 2026 09:27
@chiragjn
chiragjn enabled auto-merge (squash) August 25, 2026 09:27
@chiragjn
chiragjn merged commit b90d43f into truefoundry:main Aug 25, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helm chart version bump should honor pre release mode

3 participants