fix: preserve Helm chart prerelease mode - #394
Conversation
|
There was a problem hiding this comment.
Pull request overview
Fixes Helm chart version resolution to preserve app prerelease lanes while keeping chart numbering independent.
Changes:
- Adds a tested chart-version resolver.
- Preserves higher chart versions and same-lane RC counters.
- Integrates regression tests into CI and the release workflow.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Summary |
|---|---|
tests/scripts/resolve-chart-version.test.sh |
Adds chart-version regression cases. |
scripts/resolve-chart-version.sh |
Resolves chart versions and prerelease counters. |
package.json |
Adds the chart-version test script. |
.github/workflows/ci.yml |
Runs focused chart-version tests. |
.github/workflows/build-and-prepare-chart-release.yml |
Uses the centralized resolver during chart preparation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ceae07d. Configure here.
chiragjn
left a comment
There was a problem hiding this comment.
Mostly good to go, added minor comments
|
@chiragjn Thanks for the review! I’ve addressed and resolved both comments. Could you please take another look when you have a chance? |
|
@jayesh9747 not seeing any changes pushed to this branch addressing the comments, can you please check if commit was pushed from your local? |
|
@chiragjn let me check |
|
My bad — I had addressed the review comments locally but had not pushed the changes. The requested updates are now pushed in commit 5a34ee2, and both review threads have been resolved. Could you please take another look? |
The chart version calculation ignored the prerelease suffix already carried by the published app version. Resolve chart versions through a tested helper so RC mode and reviewed chart bumps survive workflow updates. Signed-off-by: Jayesh Savaliya <jsavaliya.tech@gmail.com>
Signed-off-by: Jayesh Savaliya <jsavaliya.tech@gmail.com>
5a34ee2 to
22521c7
Compare

Summary
rc.0and advance from the latest chart RC onmainor the open chart PRExpected lifecycle:
0.1.5 → 0.1.6-rc.0 → 0.1.6-rc.1 → 0.1.6 → 0.1.7Validation
pnpm test:chart-versionpnpm format:checkgit diff --checkCloses #384.
Note
Medium Risk
Changes release automation that sets published Helm chart versions; behavior is covered by new tests but mistakes would affect OCI chart tags.
Overview
Fixes chart release versioning so prerelease app builds get matching
-rc.Nchart versions instead of only patch bumps on stable cores.The build-and-prepare-chart-release workflow no longer inlines semver math and PR-branch comparisons. It still reads the open
release-chart/trueforgebranch for a reviewer-bumped version, then delegates toscripts/resolve-chart-version.sh, which picks the numeric core (patch bump from stable main, hold core across RCs, stabilize when the app goes stable), uses app version only for stable vs prerelease mode, maintains a chart-local RC counter (not tied to the app’s prerelease suffix), and keeps a higher core from the open chart PR.Adds
pnpm test:chart-versionand shell tests covering stable bumps, RC progression, stabilization, and preserved PR cores.Reviewed by Cursor Bugbot for commit 22521c7. Bugbot is set up for automated code reviews on this repo. Configure here.