ci(helm): drop redundant schema job + fix Lint/Unit tests name collision#280
Open
LukasWodka wants to merge 1 commit into
Open
ci(helm): drop redundant schema job + fix Lint/Unit tests name collision#280LukasWodka wants to merge 1 commit into
LukasWodka wants to merge 1 commit into
Conversation
… jobs - The `schema` job re-rendered each platform's values to /dev/null — exactly what `template` already does (and `template` also kubeconform-validates the output), so `schema` added 4 matrix jobs of zero extra coverage. Removed. (Not a required status check — branch protection requires only Lint + Unit tests.) - helm-ci's `lint`/`unittest` jobs were named "Lint"/"Unit tests", colliding with the same-named required checks that standard-checks.yml emits unconditionally on every PR. Renamed to "Helm lint"/"Helm unit tests" so the required contexts come unambiguously from standard-checks. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two cleanups to
helm-ci.yaml:schemajob — it re-rendered each platform to/dev/null, exactly whattemplatealready does (andtemplatealso runs kubeconform on the output). 4 matrix jobs of zero extra coverage. Not a required check, so safe to remove.Lint/Unit tests→Helm lint/Helm unit tests— they collided with the same-named required checks thatstandard-checks.ymlemits unconditionally on every PR. After this, the required contexts come unambiguously fromstandard-checks; branch protection (requiresLint+Unit tests) is unaffected.🤖 Generated with Claude Code