http1connection: Hide compressed content length after decoding - #3690
Open
Sanjays2402 wants to merge 1 commit into
Open
http1connection: Hide compressed content length after decoding#3690Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
Gzip decoding replaced the response body but left Content-Length describing the compressed bytes. Pass a header copy downstream so HTTP framing keeps the original metadata, then rename Content-Length alongside Content-Encoding. Add a simple HTTP client regression test for the transformed headers. Fixes tornadoweb#2743
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic gzip decompression left the upstream
Content-Lengthin response headers even though the body contained the decompressed bytes, so proxying the response could fail withHTTPOutputError.Pass a header copy downstream to preserve the original framing metadata for
HTTP1Connection, then renameContent-LengthtoX-Consumed-Content-Lengthalongside the existingContent-Encodinghandling. The regression test fails on master and the affected client/server suites pass; the full suite's sole failure also reproduces on unmodified master on macOS/Python 3.14.Fixes #2743