Skip to content

Fixes accessibility and UI issues in the new mobile nav - #450

Merged
albinazs merged 2 commits into
migration-2026from
fe-a11y-fixes-1408
Aug 18, 2026
Merged

Fixes accessibility and UI issues in the new mobile nav #450
albinazs merged 2 commits into
migration-2026from
fe-a11y-fixes-1408

Conversation

@albinazs

Copy link
Copy Markdown
Collaborator

Description of Changes Made

Fixes accessibility and UI issues in the new mobile navigation:

  1. poor color contrast for the mobile subnav (level 2) description text in the light theme
Before image
After image
  1. mobile subnav overlapping with the header when scrolling
Before image
After image

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Performance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@albinazs albinazs self-assigned this Aug 14, 2026
@albinazs
albinazs requested a review from helenb August 14, 2026 09:14
.primary-nav-dropdown-mobile {
@include z-index(nav);
@include nav-fixed-position($header-height: $header-height);
top: 0;

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this element is its own scroll container, so it must start below the header instead of spanning the full vh with a padding-top - padding scrolls away with the content, creating an overlap of the menu items with the header

&__description {
@include font-size('size-six');
display: block;
color: var(--color--grey-20);

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color confirmed by Nick L

@helenb helenb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@albinazs
albinazs merged commit cd3e8bc into migration-2026 Aug 18, 2026
8 checks passed
@albinazs
albinazs deleted the fe-a11y-fixes-1408 branch August 18, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants