Fixes accessibility and UI issues in the new mobile nav - #450
Merged
Conversation
albinazs
commented
Aug 14, 2026
| .primary-nav-dropdown-mobile { | ||
| @include z-index(nav); | ||
| @include nav-fixed-position($header-height: $header-height); | ||
| top: 0; |
Collaborator
Author
There was a problem hiding this comment.
this element is its own scroll container, so it must start below the header instead of spanning the full vh with a padding-top - padding scrolls away with the content, creating an overlap of the menu items with the header
albinazs
commented
Aug 14, 2026
| &__description { | ||
| @include font-size('size-six'); | ||
| display: block; | ||
| color: var(--color--grey-20); |
Collaborator
Author
There was a problem hiding this comment.
Color confirmed by Nick L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes Made
Fixes accessibility and UI issues in the new mobile navigation:
Before
After
Before
After
MR Checklist
Unit tests
Documentation
Browser testing
Data protection
Light and dark mode
Accessibility
Sustainability
Pattern library