ci: codex caller fires on ready_for_review; partition concurrency by draft flag#110
Merged
Merged
Conversation
…draft flag A PR opened as draft never got Codex review: draft-phase runs skip on the draft gate, and ready_for_review was not in the trigger types, so the ready click fired nothing. Adding it alone would let a stale draft-payload synchronize run cancel the ready_for_review run, so the concurrency group is partitioned by the payload draft flag (mirrors topcoder1/dotclaude#133 / #132). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Coverage Floor — mode:
|
|
No issues found. Draft-flag concurrency partition and the added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-file caller patch, fleet rollout of topcoder1/dotclaude#133.
Bug: this caller triggers on [opened, synchronize, reopened] and gates codex-classify on draft == false. A PR opened as draft therefore never gets Codex review even after being marked ready: all draft-phase runs skip on the gate, and the ready click emits ready_for_review, which was not in the trigger types. A sensitive/blocked-path PR going draft -> ready -> merge shipped with zero second-model review unless a post-ready push happened to fire a synchronize.
Fix: add ready_for_review to the trigger types, and partition the concurrency group by the payload draft flag (codex-N-draft / codex-N-live) so a stale draft-payload synchronize run cannot cancel or replace the ready_for_review run (the race fixed for pr-classify in dotclaude#132, attaxion_dev#303).
Validation: template diff actionlint-clean; Codex rounds: 4 on the canonical template PR (GATE: PASS, no P1 — see dotclaude#133).
Auto-merge rationale: manual-merge category — production infrastructure (.github/workflows/**); requires click-merge per policy.
🤖 Generated with Claude Code