Skip to content

Make Colors more Consistent - #159

Merged
XoMEX merged 3 commits into
mainfrom
fix/consistent-colors
Aug 26, 2026
Merged

Make Colors more Consistent#159
XoMEX merged 3 commits into
mainfrom
fix/consistent-colors

Conversation

@XoMEX

@XoMEX XoMEX commented Aug 18, 2026

Copy link
Copy Markdown
Member
  • Introduce SemanticMarkup class
  • Replace hardcoded colors with more semantic names
  • Move to a markup-like approach: wrap values rather than adding a ansi prefix+suffix manually

I recommend reviewing and merging #158 first. While this branch already incorporates a rename from there. And it seems Jenkins is unhappy about the current git branches, so I hope this is resolved once the target is merged into main...

- Introduce `SemanticMarkup` class
- Replace hardcoded colors with more semantic names
- Move to a markup-like approach: wrap values rather than adding a ansi prefix+suffix manually
@XoMEX
XoMEX requested a review from FelixLange1998 August 18, 2026 16:15
Base automatically changed from fix/distinguish-not-scheduled-vs-not-executed to main August 21, 2026 06:47
Comment thread src/main/java/de/rub/nds/scanner/core/report/ReportCreator.java Outdated
@XoMEX

XoMEX commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

@copilot check whether I made any mistakes while changing from colors to markup

Co-authored-by: XoMEX <7779965+XoMEX@users.noreply.github.com>

Copilot AI commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

@copilot check whether I made any mistakes while changing from colors to markup

Found one bug: in ReportPrinter.prettyAppendUnderlined(StringBuilder, String, long) (line 335), the condition was !printColorful instead of printColorful. This caused the long overload to apply underline formatting only when colors were disabled, while the String and boolean overloads did it correctly with printColorful. Fixed in the latest commit.

@XoMEX
XoMEX merged commit c8e23d9 into main Aug 26, 2026
12 checks passed
@XoMEX
XoMEX deleted the fix/consistent-colors branch August 26, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants