fix: add a second pass of resolution with no extension - #161
Merged
Conversation
Fixes #160 Currently, if the command includes a `.` (like `foo.js`), we search for `foo.js`, `foo.js.EXE`, `foo.js.CMD`, etc. However, if the command is `foo`, we only search for `foo.EXE`, `foo.CMD`, etc. This means we're not picking up files literally called `foo`. The fix here does a second pass with no extensions. This means we do the existing searching, and _if all else fails_, we look for the name as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160
Currently, if the command includes a
.(likefoo.js), we search forfoo.js,foo.js.EXE,foo.js.CMD, etc.However, if the command is
foo, we only search forfoo.EXE,foo.CMD, etc.This means we're not picking up files literally called
foo.The fix here does a second pass with no extensions. This means we do the
existing searching, and if all else fails, we look for the name as-is.