Add datasource BACKFILL skip support#17
Open
gnzjgo wants to merge 1 commit into
Open
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019e738a-931c-77cd-a057-5d5f8095e811 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16.
Summary
backfill="skip"toDatasourceOptions/define_datasource.BACKFILL skipin generated.datasourcefiles..datasourceBACKFILL skipduring migration and emits the equivalent Python option.Reproducibility
Before this change, the following datasource definition accepted the extra option but generated no
BACKFILLdirective:After this change, the generated output includes:
I also added migration coverage for parsing a legacy
.datasourcecontainingBACKFILL skipand emitting Python with'backfill': "skip".Validation
uv run --frozen pytest→105 passeduv run pythonconfirmed generated output containsBACKFILL skip.