Skip to content

feat: show provider in quick actions#955

Open
steveiliop56 wants to merge 6 commits into
mainfrom
feat/quick-actions-provider
Open

feat: show provider in quick actions#955
steveiliop56 wants to merge 6 commits into
mainfrom
feat/quick-actions-provider

Conversation

@steveiliop56

@steveiliop56 steveiliop56 commented Jun 24, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features
    • Quick Actions now shows the active login provider in the authenticated dropdown, with an icon and localized label (Local, LDAP, OAuth, and Tailscale).
  • Bug Fixes
    • Prevented conflicts by rejecting custom OAuth providers that use reserved provider names.
  • UI / Style
    • Updated the dropdown open/close visuals and adjusted logout text color styling for destructive actions.
  • Documentation
    • Added/updated translation strings for provider labels used in Quick Actions.

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 24, 2026
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dcb90f27-be59-418e-930a-cb4824a469ed

📥 Commits

Reviewing files that changed from the base of the PR and between 5b321f2 and 53301c7.

📒 Files selected for processing (1)
  • frontend/src/components/quick-actions/quick-actions.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • frontend/src/components/quick-actions/quick-actions.tsx

📝 Walkthrough

Walkthrough

Adds reserved OAuth provider validation in bootstrap. On the frontend, adds provider icons and quick-action labels, shows provider details in the authenticated dropdown, and updates logout styling.

Changes

Provider Badge Display and Reserved Name Enforcement

Layer / File(s) Summary
Reserved provider names validation
internal/model/constants.go, internal/bootstrap/app_bootstrap.go
Exports ReservedProviderNames = []string{"local", "ldap", "tailscale"} and adds a guard in the OAuth provider setup loop that returns an error if any configured provider ID matches a reserved name.
Provider badge and quick actions UI
frontend/src/components/icons/local-auth.tsx, frontend/src/components/quick-actions/quick-actions.tsx, frontend/src/lib/i18n/locales/en.json, frontend/src/lib/i18n/locales/en-US.json
Adds LocalAuthIcon, provider icon mappings, provider-detail resolution for local/ldap/oauth/tailscale, updated authenticated dropdown trigger/header rendering, and new quick-action translation keys.
Destructive logout styling
frontend/src/components/quick-actions/quick-actions.tsx, frontend/src/pages/logout-page.tsx
Updates the logout icon and logout button text styling to use destructive coloring.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 I hop through logins, bright and neat,
With badges, keys, and icons sweet.
Reserved names stay safely out,
While quick actions twinkle all about.
Hop hop! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: displaying the auth provider in Quick Actions.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/quick-actions-provider

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/bootstrap/app_bootstrap.go 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Rycochet
Rycochet previously approved these changes Jun 24, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 24, 2026
@steveiliop56 steveiliop56 changed the title feat: show provider badge in quick actions feat: show provider in quick actions Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants