Move Enterprise-only kube-controllers settings to an Enterprise configuration - #5221
Open
caseydavenport wants to merge 1 commit into
Open
Move Enterprise-only kube-controllers settings to an Enterprise configuration#5221caseydavenport wants to merge 1 commit into
caseydavenport wants to merge 1 commit into
Conversation
…guration The base kube-controllers configuration only carries fields the base render reads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Another variant-gating split. The kube-controllers configuration the base render reads is generic again; the management cluster, tenant, and Calico Cloud settings now live on an Enterprise-only configuration that wraps it.
No behavior change. The base render read none of the five settings that moved, and the Enterprise assembler is the only thing that ever set them.
One thing worth flagging for review: the managed cluster connection setting is never populated by any caller today, so the managed cluster permission and policy branches in the Enterprise assembler are unreachable. Moved it as-is rather than deleting it.
Follow-on from #5189.