Issue 1825 - Refactor internal references to ignored (attributes) to transient attributes - #1828
Open
cath-porter wants to merge 5 commits into
Open
Issue 1825 - Refactor internal references to ignored (attributes) to transient attributes#1828cath-porter wants to merge 5 commits into
cath-porter wants to merge 5 commits into
Conversation
Contributor
|
Just wanted to pop in and say I still have this on my radar to review. Things have been a bit busy after getting back from rubyconf 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename attribute_list.ignored to attribute_list.transient
Rename attribute_list.non_ignored to attribute_list.non_transient
Update DeclarationMatcher to use transient instead of ignored
#1825