Skip to content

audio: base_fw: validate dma control payload length before subtract #10888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
Jun 12, 2026
+7 −0
Merged

audio: base_fw: validate dma control payload length before subtract #10888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/audio/base_fw.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,6 +770,13 @@ __cold static int basefw_dma_control(bool first_block, bool last_block, uint32_t
}

dma_control = (struct ipc4_dma_control *)data;

/* data_offset must cover the fixed header before computing the payload size */
if (data_offset < sizeof(struct ipc4_dma_control)) {
tr_err(&ipc_tr, "DMA Control message too short: %u", data_offset);
return IPC4_ERROR_INVALID_PARAM;
}

data_size = data_offset - sizeof(struct ipc4_dma_control);

if (data_size < (dma_control->config_length * sizeof(uint32_t))) {
Expand Down
Loading