ipc3: minor fixes for ipc validation#10883
Open
lgirdwood wants to merge 2 commits into
Open
Conversation
lgirdwood
requested review from
dbaluta,
kv2019i,
lbetlej,
mmaka1 and
plbossart
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens IPC3 handling of host-supplied fields to prevent integer wrap/underflow and to ensure DMA/page-table parsing stays within fixed DSP-side buffers.
Changes:
- Add validation for
ring->pages(reject 0 and values that cannot fit in the fixedPLATFORM_PAGE_TABLE_SIZEcompressed page table) before any size arithmetic/DMA. - Replace an overflow-prone size-sum check with an overflow-safe comparison when validating host-supplied
proc->comp.hdr.sizeandproc->size.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ipc/ipc3/host-page-table.c | Validates host page count early to avoid underflow in size checks and out-of-bounds DMA/page-table parsing. |
| src/ipc/ipc3/helper.c | Prevents uint32 wraparound when validating host-provided process component sizes against SOF_IPC_MSG_MAX_SIZE. |
kv2019i
reviewed
Jun 12, 2026
kv2019i
left a comment
kv2019i
left a comment
Collaborator
There was a problem hiding this comment.
Code change is good, but please fix the commit message formatting.
Contributor
I second the above and would also add the need to fix the failing checks in CI: FAILED: [code=1] modules/sof/CMakeFiles/modules_sof.dir/home/runner/work/sof/sof/workspace/sof/src/ipc/ipc3/host-page-table.c.obj
/usr/bin/clang -DCC_OPTIMIZE_FLAGS=\"\" -DKERNEL -DK_HEAP_MEM_POOL_SIZE=2048 -DXCC_TOOLS_VERSION=\"host\" -D_POSIX_THREAD_SAFE_FUNCTIONS=200809L -D__ZEPHYR__=1 -DRELATIVE_FILE=\"../sof/src/ipc/ipc3/host-page-table.c\" -I/home/runner/work/sof/sof/workspace/build-fuzz/zephyr/include/generated/zephyr -I/home/runner/work/sof/sof/workspace/zephyr/include -I/home/runner/work/sof/sof/workspace/build-fuzz/zephyr/include/generated -I/home/runner/work/sof/sof/workspace/zephyr/soc/native/inf_clock -I/home/runner/work/sof/sof/workspace/zephyr/boards/native/native_sim -I/home/runner/work/sof/sof/workspace/zephyr/scripts/native_simulator/common/src/include -I/home/runner/work/sof/sof/workspace/zephyr/scripts/native_simulator/native/src/include -I/home/runner/work/sof/sof/workspace/zephyr/subsys/portability/posix/c_lib_ext/getopt -I/home/runner/work/sof/sof/workspace/zephyr/drivers -I/home/runner/work/sof/sof/workspace/sof/zephyr/include -I/home/runner/work/sof/sof/workspace/zephyr/kernel/include -I/home/runner/work/sof/sof/workspace/zephyr/arch/host/include -I/home/runner/work/sof/sof/workspace/sof/src/include/sof/audio/module_adapter/iadk -I/home/runner/work/sof/sof/workspace/sof/src/include/sof/audio/module_adapter/library -I/home/runner/work/sof/sof/workspace/sof/src/audio/smart_amp/CONFIG_MAXIM_DSM -I/home/runner/work/sof/sof/workspace/sof/src/audio/smart_amp/include/dsm_api/inc -I/home/runner/work/sof/sof/workspace/sof/src/platform/posix/include -I/home/runner/work/sof/sof/workspace/sof/tools/rimage/src/include -I/home/runner/work/sof/sof/workspace/sof/src/include -I/home/runner/work/sof/sof/workspace/sof/src/arch/host/include -I/home/runner/work/sof/sof/workspace/sof/third_party/include -isystem /home/runner/work/sof/sof/workspace/zephyr/lib/libc/minimal/include -isystem /home/runner/work/sof/sof/workspace/zephyr/lib/libc/common/include -fno-strict-aliasing -O2 -imacros /home/runner/work/sof/sof/workspace/build-fuzz/zephyr/include/generated/zephyr/autoconf.h -ffreestanding -fno-common -g -gdwarf-4 -fcolor-diagnostics --config=/home/runner/work/sof/sof/workspace/zephyr/cmake/toolchain/host/llvm/clang_libgcc.cfg -Wall -Wformat -Wformat-security -Wno-format-zero-length -Wno-unused-but-set-variable -Wno-typedef-redefinition -Wno-deprecated-non-prototype -Wdouble-promotion -Wno-pointer-sign -Wpointer-arith -Wno-self-assign -Wno-initializer-overrides -Wno-section -Wno-gnu -Werror=implicit-int -fno-pic -fno-pie -Werror -fno-asynchronous-unwind-tables -fstrict-overflow -Wno-vla -fmacro-prefix-map=/home/runner/work/sof/sof/workspace/sof/app=CMAKE_SOURCE_DIR -fmacro-prefix-map=/home/runner/work/sof/sof/workspace/zephyr=ZEPHYR_BASE -fmacro-prefix-map=/home/runner/work/sof/sof/workspace=WEST_TOPDIR -ffunction-sections -fdata-sections -m32 -msse2 -mfpmath=sse -fvisibility=hidden -nostdinc -isystem /usr/lib/llvm-18/lib/clang/18/include -include /home/runner/work/sof/sof/workspace/zephyr/arch/posix/include/undef_system_defines.h -fno-builtin -fsanitize-recover=all -fPIC -fsanitize=address,fuzzer -std=c17 -fno-inline-functions -std=gnu99 -MD -MT modules/sof/CMakeFiles/modules_sof.dir/home/runner/work/sof/sof/workspace/sof/src/ipc/ipc3/host-page-table.c.obj -MF modules/sof/CMakeFiles/modules_sof.dir/home/runner/work/sof/sof/workspace/sof/src/ipc/ipc3/host-page-table.c.obj.d -o modules/sof/CMakeFiles/modules_sof.dir/home/runner/work/sof/sof/workspace/sof/src/ipc/ipc3/host-page-table.c.obj -c /home/runner/work/sof/sof/workspace/sof/src/ipc/ipc3/host-page-table.c
/home/runner/work/sof/sof/workspace/sof/src/ipc/ipc3/host-page-table.c:230:20: error: use of undeclared identifier 'PLATFORM_PAGE_TABLE_SIZE'
230 | ring->pages > PLATFORM_PAGE_TABLE_SIZE * 8 / 20) {
| ^
1 error generated. |
| * below in ipc_parse_page_descriptors(). | ||
| */ | ||
| if (ring->pages == 0 || | ||
| ring->pages > PLATFORM_PAGE_TABLE_SIZE * 8 / 20) { |
Member
There was a problem hiding this comment.
8/20 magic is the only way to calculate this?
Member
Author
There was a problem hiding this comment.
Good point — I've named them so it's self-documenting now. The compressed page table stores one 20-bit entry per host page, so the number of pages whose entries fit in the buffer is (buffer_bytes * 8) / 20 (the * 8 converts the buffer size from bytes to bits). It now reads:
#define HOST_PAGE_TABLE_BITS_PER_PAGE 20
#define HOST_PAGE_TABLE_MAX_PAGES \
(PLATFORM_PAGE_TABLE_SIZE * 8 / HOST_PAGE_TABLE_BITS_PER_PAGE)The 20-bit packing is the existing on-the-wire page-table format — see ipc_parse_page_descriptors(), which unpacks 20 bits per page — so the arithmetic follows from that rather than being arbitrary.
The host-supplied ring->pages drives both the page table DMA transfer length (20 bits per page) and the DSP-side descriptor allocations, but only ring->size was sanity checked. A large page count could overflow the fixed-size page table buffer and wrap the page-count multiplication. Reject a zero or too-large page count at the single entry point before any use. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
The bounds check added two host-supplied 32-bit sizes, which could wrap and let an oversized value pass. Compare without adding by subtracting from the maximum instead. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Member
Author
|
Thanks — both addressed and force-pushed:
|
Member
Author
Seen the fuzzing failure in another unrelated PR. Checking. |
lyakh
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fixes for data passed in by host.