Skip to content

audio: codec_adapter: add llext support for dax#10331

Merged
lgirdwood merged 1 commit into
thesofproject:mainfrom
checkupup:dax_dev_main
Nov 21, 2025
Merged

audio: codec_adapter: add llext support for dax#10331
lgirdwood merged 1 commit into
thesofproject:mainfrom
checkupup:dax_dev_main

Conversation

@checkupup

Copy link
Copy Markdown
Contributor

LLEXT support for DAX.

@sofci

sofci commented Oct 28, 2025

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

reply test this please to run this test once

@checkupup

Copy link
Copy Markdown
Contributor Author

This change encounters following errors when we run on MTL platform machine:

[   51.125310] <err> llext: do_llext_load: Failed to allocate extension symbol table, ret -12
[   51.125340] <err> lib_manager: llext_manager_link_single: linking failed: -12
[   51.125346] <err> lib_manager: lib_manager_module_create: lib_manager_allocate_module() failed!
[   51.125378] <err> ipc: ipc4_init_module_instance: error: failed to init module 1000 : 0
[   51.125385] <err> ipc: ipc_cmd: ipc4: MODULE_MSG failed with err 104

Seems like symbol table size has some limitation.

See
mtrace.log
for full logs.

See
build.log
for build info.

dax_dev_overlay.conf is:

CONFIG_COMP_MODULE_ADAPTER=y
CONFIG_COMP_DOLBY_DAX_AUDIO_PROCESSING=m
CONFIG_COMP_DOLBY_DAX_AUDIO_PROCESSING_MOCK=n
CONFIG_KCPS_DYNAMIC_CLOCK_CONTROL=n

I have no idea what the limitation is.

@lgirdwood

Copy link
Copy Markdown
Member

test this please

@lgirdwood lgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm good to go ahead whilst we work on optimizing linking speed for larger modules

Comment thread src/audio/module_adapter/module/dolby/dax.c Outdated
Comment thread src/audio/module_adapter/Kconfig Outdated
Comment thread app/overlays/mtl/dax_overlay.conf

@kv2019i kv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue with "CONFIG_LLEXT_EXPERIMENTAL" warrants follow-up, but I don't think blocking this PR (given this is feature overlay specific to one platform).

I recommend adding inline comments to dax_overlay.conf for the less-than-obvious settings.

LLEXT support for dax.

Signed-off-by: Jun Lai <jun.lai@dolby.com>
@checkupup

Copy link
Copy Markdown
Contributor Author

@kv2019i I have added comment and create a new issue: #10370

@checkupup

Copy link
Copy Markdown
Contributor Author

@blin-dolby Hello, bin, please help to review this change, thx.

@blin-dolby

Copy link
Copy Markdown

@blin-dolby Hello, bin, please help to review this change, thx.

No further comments, looks good.

@lgirdwood

Copy link
Copy Markdown
Member

CI looks stuck- rerun

@lgirdwood

Copy link
Copy Markdown
Member

SOFCI TEST

@checkupup

Copy link
Copy Markdown
Contributor Author

The CI check failure does not appear to be caused by this change. The code that casue code style check failure is totally copied from src/audio/tensorflow/llext-wrap.c, is this failure allowed?

@lgirdwood lgirdwood merged commit 42da4d8 into thesofproject:main Nov 21, 2025
33 of 42 checks passed
@lgirdwood

Copy link
Copy Markdown
Member

The CI check failure does not appear to be caused by this change. The code that casue code style check failure is totally copied from src/audio/tensorflow/llext-wrap.c, is this failure allowed?

Yes, the code style checker is too picky sometimes. Its advisory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants