Support Phoenix 1.8 - #153
Open
tfwright wants to merge 1 commit into
Open
Conversation
tfwright
force-pushed
the
deps/allow-live-view-1.2
branch
3 times, most recently
from
August 9, 2026 19:26
3c4b264 to
add0369
Compare
Relax the phoenix_live_view and gettext requirements to current Phoenix 1.8 versions, adopt gettext's new backend API, and give phx-change forms ids so LiveAdmin builds cleanly on LiveView 1.2.
tfwright
force-pushed
the
deps/allow-live-view-1.2
branch
from
August 9, 2026 19:40
add0369 to
f3b5c9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes LiveAdmin usable from an app on current Phoenix 1.8 defaults, which pin newer LiveView and gettext than LiveAdmin currently allows.
phoenix_live_view:~> 1.1.0→~> 1.1(the old bound resolves to< 1.2.0, excluding LiveView 1.2).gettext:~> 0.22→~> 0.26 or ~> 1.0, and switchLiveAdmin.Gettextto theGettext.BackendAPI so it compiles without deprecation warnings on gettext 1.0. Drops support for gettext < 0.26.Also fixes a LiveView 1.2 warning: forms with
phx-changeneed anidfor form recovery after a crash/disconnect. Added ids to the resource edit, index search, select-all, and session forms (the per-row selection form uses a record-scoped id to stay unique).Verified against LiveView 1.2.8 + gettext 1.0.2:
mix compile --warnings-as-errorsclean, 45 tests / 0 failures, no form-id or gettext deprecation warnings.🤖 Generated with Claude Code