Improve form state verification and split-pane UI awareness#61
Open
DenysKuchma wants to merge 2 commits into
Open
Improve form state verification and split-pane UI awareness#61DenysKuchma wants to merge 2 commits into
DenysKuchma wants to merge 2 commits into
Conversation
DavertMik
requested changes
Jun 30, 2026
|
|
||
| const visibilityNote = visible ? 'Element IS visible in browser — Tester can use this XPath as locator.' : 'Element exists in DOM but is NOT visible. May need scrolling, a click to reveal, or is hidden.'; | ||
|
|
||
| const hit = liveElement?.attrs['data-explorbot-hit'] || null; |
Contributor
There was a problem hiding this comment.
can we here do things less ugly
if liveEelement is instance of our webEelement class
Add to liveElemet
const hit = liveElement.ourAttr('hit')| limits: typeof HTML_EXTRACTION_LIMITS; | ||
| }; | ||
|
|
||
| export function captureDomHtmlSnapshot(): string { |
Contributor
There was a problem hiding this comment.
we already have like 3 functions for html snapshot:
htmlMinimalUISnapshot
htmlCombinedSnapshot
...
should we add this to thee ones?
| return Array.from(tokens).slice(0, 8); | ||
| } | ||
|
|
||
| function describeTopElement(target: Element): string { |
Contributor
There was a problem hiding this comment.
Suggested change
| function describeTopElement(target: Element): string { | |
| function describeOverlappingElement(target: Element): string { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary