fix: replace deprecated animation and testing-module APIs - #595
Open
JeevanMahesha wants to merge 2 commits into
Open
fix: replace deprecated animation and testing-module APIs#595JeevanMahesha wants to merge 2 commits into
JeevanMahesha wants to merge 2 commits into
Conversation
JeevanMahesha
commented
Aug 7, 2026
JeevanMahesha
commented
Contributor
- Swap provideNoopAnimations() for Material's MATERIAL_ANIMATIONS token in dialog specs (provideNoopAnimations is deprecated since v20.2)
- Swap BrowserDynamicTestingModule/platformBrowserDynamicTesting for BrowserTestingModule/platformBrowserTesting in karma test.ts, and drop the now-unused @angular/platform-browser-dynamic dependency
- Swap provideNoopAnimations() for Material's MATERIAL_ANIMATIONS token in dialog specs (provideNoopAnimations is deprecated since v20.2) - Swap BrowserDynamicTestingModule/platformBrowserDynamicTesting for BrowserTestingModule/platformBrowserTesting in karma test.ts, and drop the now-unused @angular/platform-browser-dynamic dependency
JeevanMahesha
marked this pull request as draft
August 7, 2026 16:34
JeevanMahesha
marked this pull request as ready for review
August 8, 2026 02:57
timdeschryver
approved these changes
Aug 10, 2026
timdeschryver
left a comment
timdeschryver
left a comment
Member
There was a problem hiding this comment.
Thanks again for the PR @JeevanMahesha !
| "prepare": "git config core.hookspath .githooks" | ||
| }, | ||
| "dependencies": { | ||
| "@angular/animations": "22.0.2", |
Member
There was a problem hiding this comment.
Do we still need this package?
Member
There was a problem hiding this comment.
@JeevanMahesha I accidentally approved, but could you please take a look at this please.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.