Add download json button to Standalone Activities table#3675
Open
laurakwhit wants to merge 2 commits into
Open
Add download json button to Standalone Activities table#3675laurakwhit wants to merge 2 commits into
laurakwhit wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
laurakwhit
force-pushed
the
DT-4257-download-json
branch
from
34e9d02 to
b9044d5
Compare
Comment on lines
+10
to
+12
| a.href = URL.createObjectURL(file); | ||
| a.download = fileName; | ||
| a.click(); |
Contributor
There was a problem hiding this comment.
Suggested change
| a.href = URL.createObjectURL(file); | |
| a.download = fileName; | |
| a.click(); | |
| const objUrl = URL.createObjectURL(file); | |
| a.href = objUrl; | |
| a.download = fileName; | |
| a.click(); | |
| URL.revokeObjectURL(objUrl); |
if you don't revoke the object url after you're done I think it's a memory leak
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Creates a shared
DownloadJsonButtoncomponent and adds it to the/activitiespage table.Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Make sure "Download JSON" button works as expected on
/workflowstableactivitiestable/archivaltableChecklists
Draft Checklist
Merge Checklist
Issue(s) closed
DT-4257Docs
Any docs updates needed?