Skip to content

fix describe SANO API requests to include runId parameter#3661

Merged
rossedfort merged 1 commit into
mainfrom
fix-sano-api-call
Jul 13, 2026
Merged

fix describe SANO API requests to include runId parameter#3661
rossedfort merged 1 commit into
mainfrom
fix-sano-api-call

Conversation

@rossedfort

Copy link
Copy Markdown
Contributor

Description & motivation 💭

Include the runId request parameter in DescribeNexusOperationExecutionRequest so that the run a user is actually trying to view is returned instead of the most recent run.

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@rossedfort rossedfort requested a review from a team as a code owner July 10, 2026 20:26
@vercel

vercel Bot commented Jul 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Jul 10, 2026 8:26pm

Request Review

runId,
false,
);
const { input, encoding, messageType } = await extractNexusInputValues(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Argument of type 'IPayload | null | undefined' is not assignable to parameter of type 'IPayload | undefined'.

this.operationId,
this.runId,
);
} catch (error) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Argument of type 'unknown' is not assignable to parameter of type 'Error'.

@temporal-cicd

temporal-cicd Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor
Warnings
⚠️

📊 Strict Mode: 16 errors in 3 files (1.8% of 895 total)

src/lib/services/standalone-nexus-operations.ts (4)
  • L66:6: Type 'ErrorCallback' is not assignable to type '(error: unknown, toasts?: Toaster, errors?: Writable<NetworkError | null>, isBrowser?: boolean) => void'.
  • L158:6: Type '{ indexedFields?: ({ [k: string]: temporal.api.common.v1.IPayload; } | null); }' is not assignable to type '{ [k: string]: IPayload; }'.
  • L159:31: Argument of type 'Record<string, unknown>[]' is not assignable to parameter of type '{ type: "Unspecified" | "Keyword" | "Text" | "Int" | "Double" | "Bool" | "Datetime" | "KeywordList"; label: string; value?: any; }[]'.
  • L305:6: Argument of type 'IPayload | null | undefined' is not assignable to parameter of type 'IPayload | undefined'.
src/lib/utilities/standalone-nexus-operation-poller.svelte.ts (5)
  • L19:10: Property 'token' has no initializer and is not definitely assigned in the constructor.
  • L49:19: Argument of type 'unknown' is not assignable to parameter of type 'Error'.
  • L59:6: Type 'string | undefined' is not assignable to type 'string'.
  • L76:12: Type 'string | undefined' is not assignable to type 'string'.
  • L84:23: Argument of type 'unknown' is not assignable to parameter of type 'Error'.
src/lib/components/standalone-nexus-operations/start-standalone-nexus-operation-form/form.svelte (7)
  • L56:4: Type 'string | undefined' is not assignable to type 'string'.
  • L217:6: Type 'ClientValidationAdapter<{ encoding: "json/plain" | "json/protobuf"; namespace: string; endpoint: string; service: string; operation: string; identity: string; nexusHeader: { key: string; value: string; }[]; summary?: string | undefined; ... 8 more ...; idConflictPolicy?: string | undefined; }, { ...; }>' is not assignable to type 'ClientValidationAdapter<Partial<{ input: string; messageType: string; scheduleToStartTimeout: string; summary: string; details: string; idReusePolicy: string; idConflictPolicy: string; nexusHeader: never[]; encoding: "json/plain" | "json/protobuf"; ... 7 more ...; scheduleToCloseTimeout: string | undefined; }>, Reco...'.
  • L259:14: Type 'string | null | undefined' is not assignable to type 'string'.
  • L347:25: Type '{ key: string; value: string; }' is not assignable to type 'never'.
  • L347:47: Type '{ key: string; value: string; }' is not assignable to type 'never'.
  • L603:51: Property 'key' does not exist on type 'never'.
  • L612:51: Property 'value' does not exist on type 'never'.

Generated by 🚫 dangerJS against fcc54df

@rossedfort rossedfort merged commit 1bfd275 into main Jul 13, 2026
22 checks passed
@rossedfort rossedfort deleted the fix-sano-api-call branch July 13, 2026 18:40
rossedfort added a commit that referenced this pull request Jul 13, 2026
Auto-generated version bump from 2.52.0 to 2.52.1

Bump type: patch

Changes included:
- [`3be0df00`](3be0df0) fix(schedules): default absent second/minute/hour to 0 when editing (#3653)
- [`508b65b7`](508b65b) fix(schedules): default emptied second/minute/hour to 0 on submit (#3655)
- [`1f0e149c`](1f0e149) fix(workers): reject $LATEST qualifier in Lambda ARN validation (#3657)
- [`b42b0776`](b42b077) a11y(2.4.3): inert-based focus containment + restore; drop trap from native dialogs (#3598)
- [`cc491a29`](cc491a2) a11y(2.4.3): keep toast live region announcing during a focus trap [DT-4252] (#3654)
- [`ddc7f8e2`](ddc7f8e) a11y(2.4.11): add scroll-padding so sticky overlays don't obscure focused elements (#3532)
- [`b7e3a472`](b7e3a47) FilterBar icon update (#3660)
- [`09318ec6`](09318ec) Add danger PR comment for api version bump (#3662)
- [`273cc4be`](273cc4b) a11y(4.1.2): add label prop to Button primitive and enforce accessible names (#3556)
- [`4507115f`](4507115) Use an editable combobox for the Cloud Run region field (DT-4232) (#3636)
- [`694a7471`](694a747) a11y(1.4.13): migrate saved-query nav tooltips to Tooltip primitive (#3607)
- [`8b384a40`](8b384a4) a11y(4.1.2): fix nested interactive elements in Copyable component (#3558)
- [`1bfd2750`](1bfd275) fix describe SANO API requests to include runId parameter (#3661)
- [`ba18b43e`](ba18b43) a11y(4.1.2): require label on CodeBlock primitive; add aria-readonly for read-only mode (#3557)
- [`6e2290f1`](6e2290f) feat(deployments): make compute provider picker configurable (#3659)
- [`4470b76a`](4470b76) fix(workers): persist WDV compute-config edits via update mask; revert $LATEST validation (#3658)
- [`17fd591b`](17fd591) fix(nexus-operations): make start standalone nexus operation timeouts optional (#3656)

Co-authored-by: rossedfort <11775628+rossedfort@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants