a11y(4.1.2): fix nested interactive elements in Copyable component#3558
Merged
Conversation
Replaces outer <button> wrapper in clickAllToCopy mode with a <div>, moving click-to-copy into an inner <button> sibling of CopyButton. Eliminates WCAG 2.2 SC 4.1.2 violation (button inside button). A11y-Audit-Ref: 4.1.2-copyable-nested-interactive Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Only apply the `Copy ${content}` aria-label for the default slot.
With a custom slot (e.g. cloud-ui api-key-details renders "ID: {id}"
while content is just the id), the hardcoded label dropped the visible
text and broke SC 2.5.3 Label in Name. Falling back to undefined lets
the slot text name the button, as it did before this PR.
- Hoist the shared <div> wrapper and <CopyButton> out of the if/else;
both branches were identical apart from the slot wrapping.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Reviewed + verified in-browser (workflow header, long ID). Confirmed via the a11y tree that the button-in-button is gone and the copy button is properly named. Truncation is unchanged before/after (no regression). Pushed two follow-ups:
Separately filed DT-4259: copy-success isn't announced reliably (no |
ardiewen
approved these changes
Jul 13, 2026
rossedfort
added a commit
that referenced
this pull request
Jul 13, 2026
Auto-generated version bump from 2.52.0 to 2.52.1 Bump type: patch Changes included: - [`3be0df00`](3be0df0) fix(schedules): default absent second/minute/hour to 0 when editing (#3653) - [`508b65b7`](508b65b) fix(schedules): default emptied second/minute/hour to 0 on submit (#3655) - [`1f0e149c`](1f0e149) fix(workers): reject $LATEST qualifier in Lambda ARN validation (#3657) - [`b42b0776`](b42b077) a11y(2.4.3): inert-based focus containment + restore; drop trap from native dialogs (#3598) - [`cc491a29`](cc491a2) a11y(2.4.3): keep toast live region announcing during a focus trap [DT-4252] (#3654) - [`ddc7f8e2`](ddc7f8e) a11y(2.4.11): add scroll-padding so sticky overlays don't obscure focused elements (#3532) - [`b7e3a472`](b7e3a47) FilterBar icon update (#3660) - [`09318ec6`](09318ec) Add danger PR comment for api version bump (#3662) - [`273cc4be`](273cc4b) a11y(4.1.2): add label prop to Button primitive and enforce accessible names (#3556) - [`4507115f`](4507115) Use an editable combobox for the Cloud Run region field (DT-4232) (#3636) - [`694a7471`](694a747) a11y(1.4.13): migrate saved-query nav tooltips to Tooltip primitive (#3607) - [`8b384a40`](8b384a4) a11y(4.1.2): fix nested interactive elements in Copyable component (#3558) - [`1bfd2750`](1bfd275) fix describe SANO API requests to include runId parameter (#3661) - [`ba18b43e`](ba18b43) a11y(4.1.2): require label on CodeBlock primitive; add aria-readonly for read-only mode (#3557) - [`6e2290f1`](6e2290f) feat(deployments): make compute provider picker configurable (#3659) - [`4470b76a`](4470b76) fix(workers): persist WDV compute-config edits via update mask; revert $LATEST validation (#3658) - [`17fd591b`](17fd591) fix(nexus-operations): make start standalone nexus operation timeouts optional (#3656) Co-authored-by: rossedfort <11775628+rossedfort@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<button>wrapper inclickAllToCopymode with a<div class="group">, moving the click-to-copy action into an inner<button>sibling ofCopyButtonaria-label={\Copy ${content}`}` so screen readers announce it meaningfullygroupclass stays on the<div>, sogroup-hover:visible/group-focus-within:visibleTailwind utilities continue to work for theCopyButtonrevealTest plan
clickAllToCopymode renders<div>wrapping two sibling buttons (no button-in-button)CopyButtonbecomes visible viagroup-hover:visibleCopyButtonstays visible viagroup-focus-within:visibleA11y-Audit-Ref: 4.1.2-copyable-nested-interactive
🤖 Generated with Claude Code