Extract common worker commands dispatch logic - #10658
Closed
rkannan82 wants to merge 6 commits into
Closed
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Nexus dispatch-to-worker and error handling logic was duplicated between service/history (workflow-based activities) and chasm/lib/activity (standalone). Extract into common/workercommands so both can share it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Tests cover DispatchToWorker (success, RPC error, upstream timeout, worker failure, non-retryable handler error, transport error, multiple commands) and HandleDispatchError (all error classification paths including CanceledError). Moved HandleDispatchError tests from service/history since the logic now lives in the shared package. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Closing — this work landed on main via #10849. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extract the Nexus dispatch-to-worker and error handling logic into a shared
common/workercommandspackage, so both workflow-based and standalone activity cancel command dispatch can reuse it.How did you test it?
🤖 Generated with Claude Code