Skip to content

Drop PHP 8.1 support #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sachinsharma3191 wants to merge 3 commits into
base: master
Choose a base branch
from
+18 −5
Open

Drop PHP 8.1 support #793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c435813
Drop PHP 8.1 support
sachinsharma3191 Aug 12, 2026
4ac7dc8
Merge branch 'master' into chore/790-drop-php81
sachinsharma3191 Aug 17, 2026
af56285
Cache runtime binaries to avoid GitHub API rate limits
sachinsharma3191 Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions .github/workflows/run-test-suite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
fail-fast: ${{ inputs.fail-fast }}
matrix:
php:
- 8.1
- 8.2
- 8.3
- 8.4
Expand All @@ -67,7 +66,7 @@
# Add Windows
- os: windows-latest
extensions-suffix: ', protobuf'
php: 8.1
php: 8.2
dependencies: highest
steps:
- name: Set Git To Use LF
Expand All @@ -94,14 +93,28 @@

- name: Validate lowest dependencies
id: validate
if: matrix.dependencies == 'lowest' && matrix.php == '8.1'
if: matrix.dependencies == 'lowest' && matrix.php == '8.2'
env:
COMPOSER_POOL_OPTIMIZER: 0
run: vendor/bin/validate-prefer-lowest
continue-on-error: true

- name: Download binaries
- name: Cache runtime binaries
id: cache-binaries
if: inputs.download-binaries == true
uses: actions/cache@v4

Check failure on line 105 in .github/workflows/run-test-suite.yml

View workflow job for this annotation

GitHub Actions / opengrep/scan 

security.gha.unpinned-action: Unpinned action reference `actions/cache@v4`: this `uses:` resolves a mutable ref (tag or branch), so the code that runs in CI can change without this line changing. A compromised upstream can repoint the tag and execute arbitrary code with access to this repository's secrets and `GITHUB_TOKEN` (`tj-actions/changed-files`, March 2025). Pin to the full 40-character commit SHA with the resolved version in a trailing comment, e.g. `uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2`. Prefer `deputy pin --ecosystems github-actions`, which resolves the ref, writes a version comment that reflects the most specific ref actually pointing at that commit, and verifies the SHA is reachable from a real branch upstream. That last check matters: pinning alone does not detect imposter or dangling commits, and this rule only sees the shape of the ref, never its provenance. Reusable workflow calls (`owner/repo/.github/workflows/x.yml@ref`) run with the same trust as actions and are pinned the same way. Not reported, by campaign policy: `temporalio/*` refs (first-party, pinned by internal process), local `./` actions, self-repository `$/` refs (resolve to the running commit, so they are already pin-equivalent), and `docker://` images (pinned by digest as a separate ecosystem).
with:
path: |
./rr
./rr.exe
./temporal
./temporal.exe
./temporal-test-server
./temporal-test-server.exe
key: ${{ runner.os }}-binaries-${{ hashFiles('dload.xml') }}

- name: Download binaries
if: inputs.download-binaries == true && steps.cache-binaries.outputs.cache-hit != 'true'
run: composer get:binaries

- name: Run tests
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"source": "https://github.com/temporalio/sdk-php"
},
"require": {
"php": ">=8.1",
"php": ">=8.2",
"ext-curl": "*",
"ext-json": "*",
"google/common-protos": "^4.9",
Expand Down
Loading