Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
✅ Docs build passed |
Contributor
📖 Docs PR preview links
|
| @@ -0,0 +1,254 @@ | |||
| --- | |||
| id: nexus-standalone-activity | |||
| title: Nexus Standalone Activity | |||
Contributor
There was a problem hiding this comment.
Reading this gave me an interesting thought . Should this doc live under SAA rather than under Nexus. The PRD names this feature is Standalone Activity: Start from Nexus, which is actually a clearer name for this. If we leave here the name really should be something like Standalone Activity Started By Nexus
Contributor
Author
There was a problem hiding this comment.
I had a lot of similar thoughts about naming confusion. I'm not at all sure!
Contributor
|
Looks great! When it's ready for review, feel free to drop a comment and post it in the slack channel then someone from the team will review it! |
| ) (temporalnexus.TemporalOperationResult[GreetingOutput], error) { | ||
| return temporalnexus.StartActivity(ctx, nc, client.StartActivityOptions{ | ||
| ID: "greet-" + opts.RequestID, | ||
| TaskQueue: TaskQueueName, |
Contributor
There was a problem hiding this comment.
nit: Task queue should be optional
Contributor
Author
There was a problem hiding this comment.
If I am getting this right, it seems like it is in the other four languages, but not Java? That might be something we need to fix
| </SdkTabs.DotNet> | ||
| </SdkTabs> | ||
|
|
||
| ## Coming from the earlier handler APIs |
Contributor
There was a problem hiding this comment.
I would add a note that there is no issue if they have workflow operations in progress. TemporalOperationHandler can cancel them just fine
Co-authored-by: Quinn Klassen <klassenq@gmail.com>
Co-authored-by: Quinn Klassen <klassenq@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note for documentation reviewers - do not review or merge. I am sending this to some internal folks as we are discussing what we want to do.
Matching sample Java code: temporalio/samples-java#793
┆Attachments: EDU-6917 Nexus V2 Documentation - don't review or merge!!