Skip to content

fix(testing): allow to throw exceptions#2184

Merged
brendt merged 3 commits into
3.xfrom
throw-exceptions
Jun 24, 2026
Merged

fix(testing): allow to throw exceptions#2184
brendt merged 3 commits into
3.xfrom
throw-exceptions

Conversation

@brendt

@brendt brendt commented Jun 24, 2026

Copy link
Copy Markdown
Member

No description provided.

@brendt

brendt commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

Some mago updates as well. I'll just keep it in the same PR

@github-actions

Copy link
Copy Markdown

Benchmark Results

Comparison of throw-exceptions against 3.x (453fdd8baba52a3a534c6c3f67c240848af40006).

Open to see the benchmark results
Benchmark Set Mem. Peak Time Variability
DiscoveryScanBench(benchFullDiscoveryScan) - 24.680mb +0.04% 18.681ms +5.76% ±1.89% +246.31%
ViewRenderBench(benchExpressions) - 24.533mb +0.04% 490.817μs -5.75% ±2.66% -13.43%

Generated by phpbench against commit fe1d204

@brendt brendt merged commit 69baa88 into 3.x Jun 24, 2026
76 checks passed
@brendt brendt deleted the throw-exceptions branch June 24, 2026 06:46
@innocenzi

Copy link
Copy Markdown
Member

Curious what was the use case here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants