iris-gui: drop baked status bar; add model/resolution to New Machine#55
Merged
Merged
Conversation
Two GUI tweaks: - Stop baking the emulator status bar (MIPS/NET/SCSI/LED) into the guest frame. The GUI capture renderers drew it at height-16, which both duplicated iris-gui's own egui status chrome and overwrote the guest's bottom 16 scanlines (the native iris window still draws it as a separate strip below the display, unaffected). The status_bar_only heartbeat tick now early-returns since there's nothing bar-specific left to push. - Add "Machine model" (MachineProfile) and "Display resolution" (NewportResolution) dropdowns to the New Machine dialog, reusing the existing enums. Added a `pub const ALL` to each and pointed both the Config tab and the new dialog at it, so the variant lists live in one place and can't drift. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two GUI tweaks:
Stop baking the emulator status bar (MIPS/NET/SCSI/LED) into the guest frame. The GUI capture renderers drew it at height-16, which both duplicated iris-gui's own egui status chrome and overwrote the guest's bottom 16 scanlines (the native iris window still draws it as a separate strip below the display, unaffected). The status_bar_only heartbeat tick now early-returns since there's nothing bar-specific left to push. This seemed to have been introduced in the recent "major" push
Add "Machine model" (MachineProfile) and "Display resolution" (NewportResolution) dropdowns to the New Machine dialog, reusing the existing enums. Added a
pub const ALLto each and pointed both the Config tab and the new dialog at it, so the variant lists live in one place and can't drift.