test: drop irix_install_scsi_disk_present (fixes CI failure)#52
Merged
Merged
Conversation
`irix_install_scsi_disk_present` asserted that `irix-install/scsi1.raw` exists on disk, but that root image is gitignored and never present in CI or a fresh clone, so the test fails on every runner. It also isn't a real invariant: a root disk may be supplied as either a raw image or a CHD, so the specific `.raw` path is not required. The test exercised no emulator behavior — it only checked for a local artifact — so remove it and update the module doc to note the smoke config takes a raw or CHD disk. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mainCI currently fails on theRun testsstep:The test asserts that
irix-install/scsi1.rawexists on disk:But that root image is gitignored and is never present on a CI runner or a fresh clone, so the test fails on every build. It also isn't a real invariant: a root disk can be supplied as either a raw image or a CHD, so requiring the specific
.rawpath is wrong.Fix
The test exercises no emulator behavior — it only checks for a local artifact — so this removes it and updates the module doc comment to note the smoke config takes a raw or CHD disk. The remaining 15 profile tests still pass.
Introduced in f2d0bff (Indigo2 IP22 platform); unrelated to any single feature PR, it just surfaces on every run.
🤖 Generated with Claude Code