PDF parity: add summary + severity cards to PDF report (#167) - #233
Merged
Conversation
…167) The PDF report lacked the summary sections the web HTML has: target/duration info and the CVSS severity breakdown (Critical/High/Medium/Low counts). Ported both cards from nmap-modern.xsl into the PDF stylesheet so client-facing PDFs surface severity at a glance instead of burying CVEs in raw script output. Verified end-to-end: ran a complete+PDF scan on 127.0.0.1/32, regenerated PDF via the app's Playwright converter - both summary sections render, xsltproc validates.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #167 / #160 (report rendering parity).
Change
The PDF report was missing the summary cards the web HTML has. Ported from nmap-modern.xsl into nmap-pdf-olive-legacy.xsl:
These now appear on page 1 of client-facing PDFs so severity is visible at a glance instead of being buried in raw script output on later pages.
Verification
Refs #167, #160