Skip to content

Fix dead scan buttons: frontend event aliases + runtime_store kwarg #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
techmore merged 1 commit into from
Aug 22, 2026
Merged

Fix dead scan buttons: frontend event aliases + runtime_store kwarg #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions nmapui/app_scan_runtime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,15 @@ def start_scan_task(
logger,
settings_state,
vulners_script,
runtime_store=None,
):
return start_scan_task_impl(
sid=sid,
target=target,
broadcaster=broadcaster,
emit_to_client=emit_to_client,
get_client_state=get_client_state,
runtime_store=runtime_store,
ensure_job_not_cancelled=ensure_job_not_cancelled,
idle_state_manager=idle_state_manager,
update_job_progress=update_job_progress,
Expand Down
34 changes: 29 additions & 5 deletions nmapui/handlers/scan_jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,16 @@ def register_scan_job_handlers(socketio, deps):
generate_report_task = deps["generate_report_task"]
generate_pdf_from_saved_task = deps.get("generate_pdf_from_saved_task")

@socketio.on("start_scan")
@require_socket_auth()
def start_scan(data):
def _start_scan_core(data, extra=None):
payload = dict(extra or {})
if isinstance(data, dict):
target = data.get("target", "")
payload.update(data)
else:
target = str(data) if data else ""
payload["target"] = str(data) if data else ""
target = payload.get("target", "")

if not isinstance(target, str):
target = str(target)

is_valid, error_msg = validate_target(target)
if not is_valid:
Expand Down Expand Up @@ -51,6 +54,27 @@ def start_scan(data):
emit_job_status(request.sid, "scan")
socketio.start_background_task(start_scan_task, request.sid, target)

# Legacy event names emitted by the frontend buttons (quick/complete/dragnet).
@socketio.on("start_quick_scan")
@require_socket_auth()
def start_quick_scan(data):
_start_scan_core(data)

@socketio.on("start_complete_scan")
@require_socket_auth()
def start_complete_scan(data):
_start_scan_core(data)

@socketio.on("start_dragnet_scan")
@require_socket_auth()
def start_dragnet_scan(data):
_start_scan_core(data)

@socketio.on("start_scan")
@require_socket_auth()
def start_scan(data):
_start_scan_core(data)

@socketio.on("generate_report")
@require_socket_auth()
def generate_report_event(data):
Expand Down
Loading