Skip to content

Fixed race-condition for streambroker. #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s3rius merged 1 commit into from
Jun 23, 2026
+24 −21
Merged

Fixed race-condition for streambroker. #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 24 additions & 21 deletions taskiq_redis/redis_broker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,28 +295,31 @@ async def listen(self) -> AsyncGenerator[AckableMessage, None]:
)
logger.debug("Starting fetching unacknowledged messages")
for stream in [self.queue_name, *self.additional_streams.keys()]:
lock = redis_conn.lock(
pipe = redis_conn.pipeline()
lock = pipe.lock(
f"autoclaim:{self.consumer_group_name}:{stream}",
timeout=self.unacknowledged_lock_timeout,
)
if await lock.locked():
continue
async with lock:
pending = await redis_conn.xautoclaim(
name=stream,
groupname=self.consumer_group_name,
consumername=self.consumer_name,
min_idle_time=self.idle_timeout,
count=self.unacknowledged_batch_size,
)
logger.debug(
"Found %d pending messages in stream %s",
len(pending[1]),
stream,
await lock.acquire()
await pipe.xautoclaim(
name=stream,
groupname=self.consumer_group_name,
consumername=self.consumer_name,
min_idle_time=self.idle_timeout,
count=self.unacknowledged_batch_size,
)
await lock.release()
results = await pipe.execute()
pending = results[1]

logger.debug(
"Found %d pending messages in stream %s",
len(pending[1]),
stream,
)
for msg_id, msg in pending[1]:
logger.debug("Received message: %s", msg)
yield AckableMessage(
data=msg[b"data"],
ack=self._ack_generator(id=msg_id, queue_name=stream),
)
for msg_id, msg in pending[1]:
logger.debug("Received message: %s", msg)
yield AckableMessage(
data=msg[b"data"],
ack=self._ack_generator(id=msg_id, queue_name=stream),
)
Loading