chore(deep-clean): recover orphaned hardenings + dedup bench gates + de-dup steer-firewall#187
Merged
Conversation
…s (reconciled with #185)
…s; configurable worker provider (dedup the gate zoo)
…st-driver-hook; document canonical atom
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deep-clean sweep across the debt the self-audit surfaced. Behavior-preserving — no runtime semantics change; full gate green (lint + typecheck + 676 tests + build + bench tsc). Net −180 LOC of duplication/dead-code, plus two lost hardenings recovered.
Done as three file-disjoint tracks (parallel worktrees, each self-verified) then integrated + gated together.
P0 — recover orphaned hardenings (
3d7fdff)Two sandbox hardenings were lost when PR #183 squash-merged only its CLAUDE.md commit, stranding the later pushes. Recovered onto current main, reconciled with #185's cold-start recovery (additive, no overlap):
openSandboxRun's artifact read now does a bounded 4-attempt, abort-aware retry (injectablereadRetryDelayMs, default 1000) — a transientResource not foundno longer becomes a permanent fake-empty patch (the bug that gutted the commit0 Layer-1 runs, 14/24 reads 404'd).acquireSandbox.isRetryablenow treats create-thrownEdge data plane not reachable/Provision failed/Failed to create/Too Many Requestsas retryable (retry onto a fresh host). The terminalis failedfast-fail invariant is preserved (its test still passes).P1 — dedup the bench gate zoo (
cb47904)bench/src/stats.mtssingle-sourcesrunPool+pairedLift+makeRng(were copy-pasted across 5 gates).corpus.tsgainsbuildRunRecordFromAttempts(5 gates hand-assembled theRunRecordliteral); each gate's exact recorded values preserved via overrides.WORKER_PROVIDER ?? 'openai-compat'(was hardcodedopenai, which rejected cheap router models).P2 — runtime semantic debt (
5f67497)assertTraceDerivedFindings) collapses to one canonical site (cycle-checked:dynamic.tsnow imports thepersonify/analyst.tsimpl, private copy deleted).createAnalystDriverHook(0 non-test callers, grep-verified).Deliberately out of scope (own PRs)
Routing the gates through
runExperiment(kernel) and demoting one of the three atom-substrates — behavior-changing redesigns, not a hygiene pass.