fix: address code review safety findings#27
Merged
Conversation
tae2089
marked this pull request as ready for review
July 16, 2026 16:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CCG_WEBHOOK_SECRETand update English/Korean operator guidanceWhy
The full repository review found six safety and data-integrity issues. Source symlinks could escape the analysis root, unreadable files could be mistaken for deletions, repositories from different owners could collide in one namespace, Wiki output accepted traversal paths, malformed docs manifests were silently ignored, and webhook secrets had to be passed through process arguments.
Impact
Build and update ingestion now use stable no-follow source reads. Incremental updates preserve graph state when a source cannot be read. Ambiguous webhook configurations fail before runtime initialization. Invalid Wiki namespaces and malformed docs manifests fail before output mutation. Operators can inject webhook secrets through the environment while retaining explicit flag override behavior.
Verification
CGO_ENABLED=1 go test -tags fts5 ./... -count=1CGO_ENABLED=1 go vet -tags fts5 ./...ccg build .ccg docs --out docsccg lint(one pre-existing unrelated unannotated-symbol warning remains)