Skip to content

fix: address code review safety findings#27

Merged
tae2089 merged 1 commit into
mainfrom
codex/fix-review-findings
Jul 17, 2026
Merged

fix: address code review safety findings#27
tae2089 merged 1 commit into
mainfrom
codex/fix-review-findings

Conversation

@tae2089

@tae2089 tae2089 commented Jul 16, 2026

Copy link
Copy Markdown
Owner

Summary

  • reject source-file symlinks and preserve unreadable files during incremental reconciliation
  • reject multi-owner webhook admission while repo-name-only namespaces are in use
  • validate Wiki namespace output paths and stop docs generation on malformed manifests
  • support CCG_WEBHOOK_SECRET and update English/Korean operator guidance

Why

The full repository review found six safety and data-integrity issues. Source symlinks could escape the analysis root, unreadable files could be mistaken for deletions, repositories from different owners could collide in one namespace, Wiki output accepted traversal paths, malformed docs manifests were silently ignored, and webhook secrets had to be passed through process arguments.

Impact

Build and update ingestion now use stable no-follow source reads. Incremental updates preserve graph state when a source cannot be read. Ambiguous webhook configurations fail before runtime initialization. Invalid Wiki namespaces and malformed docs manifests fail before output mutation. Operators can inject webhook secrets through the environment while retaining explicit flag override behavior.

Verification

  • CGO_ENABLED=1 go test -tags fts5 ./... -count=1
  • CGO_ENABLED=1 go vet -tags fts5 ./...
  • race tests for workflow, reposync, contentfiles, docs, and ccg-server
  • source-built ccg build .
  • source-built ccg docs --out docs
  • source-built ccg lint (one pre-existing unrelated unannotated-symbol warning remains)

@tae2089
tae2089 marked this pull request as ready for review July 16, 2026 16:17
@tae2089
tae2089 merged commit 5404e24 into main Jul 17, 2026
1 check passed
@tae2089
tae2089 deleted the codex/fix-review-findings branch July 17, 2026 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant